Add and improve annotations for all mappers in pymbolic.mapper#222
Merged
inducer merged 22 commits intoinducer:mainfrom Nov 3, 2025
Merged
Add and improve annotations for all mappers in pymbolic.mapper#222inducer merged 22 commits intoinducer:mainfrom
inducer merged 22 commits intoinducer:mainfrom
Conversation
alexfikl
commented
Nov 1, 2025
alexfikl
commented
Nov 1, 2025
alexfikl
commented
Nov 1, 2025
alexfikl
commented
Nov 1, 2025
Owner
|
Ty! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of that:
exprpositional only, following on Make Mapper.map_ methods take expr as positional only #221 (making it harder to revert, so I'm happy to wait on this)UP031andUP032) in there.constant_converter,optimize,persistent_hash.